search

imglib / imglib2-roi

Regions of interest (ROIs) and labelings for ImgLib2
Other
8 stars 8 forks source link

Why Void instead of a new VoidType? #20

Closed IdealOutage closed 8 years ago

IdealOutage commented 8 years ago

Why is a LabelRegion an IterableInterval of type java.lang.Void instead of a new empty VoidType? Now every implementation which is uses IterableInterval<T extends Type> etc. is broken.

tpietzsch commented 8 years ago

@seebacherd I don't understand. What is broken now? What would cahnge if we used VoidType instead?

dietzc commented 8 years ago

@seebacherd as already mentoined in skype: Can you name a few scenarios where the Type property is required by your implementation which can also be used without the property (because VoidType has no property at all and https://github.com/imglib/imglib2/blob/master/src/main/java/net/imglib2/IterableInterval.java is not typed on Type?

dietzc commented 8 years ago

I think this can be closed

tpietzsch commented 8 years ago

thanks @dietzc