Added n-dimensional elipsoid and rectangle ROIs, as well as binary operations for ROIs (union, intersection,...)

imglib / imglib2-roi

Regions of interest (ROIs) and labelings for ImgLib2

Other

8 stars 8 forks source link

Added n-dimensional elipsoid and rectangle ROIs, as well as binary operations for ROIs (union, intersection,...) #23

Closed haesleinhuepf closed 8 years ago

ctrueden commented 8 years ago

I would suggest massaging the history a bit to clean things. But this looks like an awesome direction! Nice work!

acardona commented 8 years ago

Question @haesleinhuepf : ImgLib2 already has an n-dimensional ellipse roi, by @LeeKamentsky : https://github.com/imglib/imglib2-roi/blob/master/src/main/java/net/imglib2/roi/EllipseRegionOfInterest.java

Is the new one different in some way?

haesleinhuepf commented 8 years ago

Yes it is. The new one is compatible with the Polygon class in the same folder. I talked to @tpietzsch and found out that the class you mentioned was marked as deprecated because it does not implement the interfaces RealRandomAccessibleRealInterval< BoolType > and Contains< RealLocalizable >. But all geometric structures should have these interfaces to make them uniformly usable.

acardona commented 8 years ago

@haesleinhuepf Sounds great. Thanks for your contribution!

haesleinhuepf commented 8 years ago

I recreated the pull request with a rewritten history