search

imglib / imglib2-roi

Regions of interest (ROIs) and labelings for ImgLib2
Other
8 stars 8 forks source link

Adding an interval parameter in ROIUtils.bresenham() #27

Open hadim opened 8 years ago

hadim commented 8 years ago

That would be nice to have an interval parameter such as in Line.getInterpolatedPolygon() (https://github.com/imagej/ImageJA/blob/master/src/main/java/ij/gui/Roi.java#L439) in ROIUtils.bresenham().

hadim commented 8 years ago

For now ROIUtils.bresenham() does not return a number of points that correspond to the rounded euclidean distance of p1 and p2 in ROIUtils.bresenham({p1, p2}) while it's the case with Line.getInterpolatedPolygon(interval=1).

hadim commented 8 years ago

Any toughs @tpietzsch ?

ctrueden commented 7 years ago

@hadim When you close an issue, can you please include a note why?

hadim commented 7 years ago

Sorry. I was reviewing old issues and because I didn't find any more activities beside me here I thought it would be best to just close it.

I guess I was tired when I did that. I'll just re open it.

imagejan commented 1 year ago

Note that meanwhile, with https://github.com/imglib/imglib2-roi/commit/a9cebea8fbcc67b8e2854cc07d32d2b323d8d671, the bresenham() method moved to GeomMaths: https://github.com/imglib/imglib2-roi/blob/46e88901c684215b7da82cdd3518b0c56ba96e67/src/main/java/net/imglib2/roi/geom/GeomMaths.java#L256-L260