imglib / imglib2-roi

Regions of interest (ROIs) and labelings for ImgLib2
Other
8 stars 8 forks source link

Mask/Labeling Conversion Methods #45

Open awalter17 opened 5 years ago

awalter17 commented 5 years ago

Hello!

The goal of this PR is to add mechanisms for going between Labelings and MaskPredicates.

Changes this branch makes:

Notes:

Please let me know if you have any questions, or if any changes are necessary!

ctrueden commented 5 years ago

Rebased over latest master to fix conflicts.

ctrueden commented 4 years ago

@awalter17 Do you need this for KNIME? I vaguely recall you mentioning work along these lines for KNIME back in September. Should we prioritize merging this?

stelfrich commented 4 years ago

@ctrueden If I am not mistaken, @awalter17 had invested some more time after discussions we had about KNIME's OMERO integration. @gab1one's implementation to read ROIs from OMERO is a little suboptimal and should be handled upstream..

awalter17 commented 4 years ago

@ctrueden thanks for fixing the conflicts! It would be nice to get this merged, because I am starting forget what I did and why. However, I don't think this merge is currently blocking anyone. So I would say this merge is "nice to have", but not immediately critical.

As @stelfrich mentioned, this PR came out of discussions about KNIME's OMERO integration. As I recall, KNIME currently uses Labelings for ROIs but ImageJ-OMERO uses MaskPredicate ROIs, so the KNIME OMERO integration currently lacks ROI support. This PR would be a first step towards ROI support in the KNIME OMERO integration.