imglib / imglib2-roi

Regions of interest (ROIs) and labelings for ImgLib2
Other
9 stars 8 forks source link

Fix NullPointerException triggered by calling imgLabeling.getType() #73

Closed maarzt closed 2 months ago

maarzt commented 3 months ago

The bug was discovered by compiling and testing Labkit against imglib2-7.1. Trying to use the brush in Labkit would trigger this NullPointerException.

I'm unsure about the rules for implementing the new getType() so please have a closer look at my suggested change and whether is correct.

I also noticed that (A) imgLabeling.getType().createVariable() would behave differently than (B) imgLabeling.randomAccess().get().createVariable(). (A) creates a LabelingType with a independent LabelMapping while (B) creates a LabelingType with the same LabelMapping as the imgLabeling. In Labkit I'm now using implementation (B) because a need the same LabelMapping in order for LabelingType.set(...) to work properly.