imglib / imglib2

A generic next-generation Java library for image processing
http://imglib2.net/
Other
302 stars 91 forks source link

Add new Views.expand...() signatures #169

Open tpietzsch opened 7 years ago

tpietzsch commented 7 years ago

We should add

expandBorder( final RandomAccessibleInterval<T> source, final long border )

(etc) to accompany

expandBorder( final RandomAccessibleInterval<T> source, final long... border )

(etc). meaning expand by int border on every side.

--> Just like it is done in the Intervals.expand methods...

axtimwalde commented 7 years ago

How about

pad( final RandomAccessibleInterval<T> source, final long padding );
pad( final RandomAccessibleInterval<T> source, final long... padding );

?

tpietzsch commented 7 years ago

expandBorder, expandMirrorSingle etc are already there. Do you mean that you would like to deprecate them and introduce padBorder, padMirrorSingle, etc?

axtimwalde commented 7 years ago

not worth it, just liked the word pad more for a second

tpietzsch commented 7 years ago

I also like it more. Not per se, but because it is less easy to confuse with "extend"

hanslovsky commented 6 years ago

It can be annoying with autocomplete, so we could consider replacing "expand" with "pad" (deprecating the expand methods).