search

imglib / imglib2

A generic next-generation Java library for image processing
http://imglib2.net/
Other
302 stars 93 forks source link

Views.bundle returns BundleView, but BundleView class is not public #351

Open cmhulbert opened 11 months ago

cmhulbert commented 11 months ago

Views.bundle returns a BundleView but the class BundleView is not public, so effectively Views.bundle cannot be used. I believe BundleView should be public

tpietzsch commented 11 months ago

...or Views.bundle should return RandomAccessible<RandomAccess<T>>?

cmhulbert commented 11 months ago

Yeah, It could go either way. the only field in BundleView is protected, so I think it would effectively be the same? I'm not sure what the thinking is with other View types, like IntervalView, but it may be nice to create BundleView without View.bundle or to subclass them, for example, a BundleView that takes an RAI and is itself also an RAI

tpietzsch commented 11 months ago

I'm not sure what the thinking is with other View types, like IntervalView,

There is not much thinking... :-) Actually, I would eventually prefer to hide all these special View types and have the Views methods all return only basic RandomAccessible, RandomAccessibleInterval, etc...