search

imgly / background-removal-js

Remove backgrounds from images directly in the browser environment with ease and no additional costs or privacy concerns. Explore an interactive demo.
https://img.ly/showcases/cesdk/web/background-removal/web
GNU Affero General Public License v3.0
5.49k stars 339 forks source link

fix: Change lodash to lodash.memoize #120

Closed vanling closed 1 month ago

vanling commented 1 month ago

fix: https://github.com/imgly/background-removal-js/issues/78

I still had a problem with loading the node lib on Nuxt3 (server) I believe this is the way to fix that issue where the dependency could not be found.

My knowledge of npm with multiple packages like this is minimal, so I hope i did this right

vanling commented 1 month ago

Maybe this only happened when i tried to use the web version. ( I might close this soon)

Update: ok, so this missing memoize/lodash only happened when using the browser version in nuxt, the node version worked. ( i think i messed up by switching in between.)

Leaving this open to hear your thoughts, might stil be a good change to only import the memoize function instead of the whole lib

DanielHauschildt commented 1 month ago

Is it still a problem in 1.5 that was released last week? The issue you are referring to was already solved before. It might be a regression though.

vanling commented 1 month ago

So it happened only with the 'browser version', node version works ok in Nuxt/server. I will take another look tomorrow with the browser version in Nuxt/frontend.

vanling commented 1 month ago

@DanielHauschildt closing, can not reproduce on browser or server. I guess I mixed up node and browser version the last time.