imgntn / j360

360 Video and Photo Capture in 4K for Three.js
291 stars 17 forks source link

Camera in video starts pointed to left even after adjustments to camera.position #3

Closed sjcobb closed 5 years ago

sjcobb commented 5 years ago

Hi, is there a certain order I should be adding the CCapture capture code, I can't get my changes to camera.position to have an effect once the video is processed, it always starts pointing to the left of the intended target.

Thanks!

imgntn commented 5 years ago

Heya -- @sjcobb! It's been a while since I've tinkered with this code but I took a look last night and wanted to update you.

I will update the docs but this is a failing on my part to clearly explain how things work, more than a technical problem.

Assuming you're running index.html

}



Hope that all helps, and I'll try to make things easier and more clear soon.

Best,
@imgntn 
sjcobb commented 5 years ago

Thanks @imgntn ! I appreciate the explanation and adding a parameter to pass the camera to the manager would be great. I was able to adjust the camera slightly and almost got it to point directly to the fire as intended, here is the code and resulting YouTube video: https://www.youtube.com/watch?v=5ntBNHxNHV0 https://github.com/sjcobb/fire-temple/blob/master/camp/js/camp-scene.js

My issue is really in the video editing realm, not with this project. I found a few tutorials to help in the future (uses 'offset effect') and I may need to invest in decent editor software.

Anyways, if you'd like, I would love to help with this project. I think it has a lot of potential for helping JS devs to gain a wider audience for their work, I know I'm planning to use it often to show some of my CodePen demos on YouTube.

imgntn commented 5 years ago

There's a feature on Facebook to set the start view for 360 photos (& videos?) .

Too bad nothing similar for YouTube

I don't think I'm copying the camera rotation into the cubeCamera the same way that I am with the position; I wonder if that's why changes to the rotation aren't sticking for you. I hadn't thought that people might want "front" to be a different direction than what it defaults to.

I'd be happy to have some help with this; it was a cool feature to add to three.js but a bit of a hack in some ways :) Agree that it gives folks a chance to showcase their sketches where people will actually see them - on social media. At least until we can embed webGL scenes on the timeline / YouTube directly!

Let me know what you think could be improved and I'll try to get back up to speed on what exactly I did previously :)