search

imgproxy / imgproxy-helm

MIT License
60 stars 56 forks source link

Use mergeOverwrite to allow overriding limits.cpu with null #139

Closed erulabs closed 1 year ago

erulabs commented 1 year ago

Currently, the default CPU limit of "1" cannot be removed, because of the usage of merge here. Using mergeOverwrite will allow us to define "cpu: null" and wipe the CPU limit.

Note: It's worth a mention that in general, CPU limits are an anti-pattern and usually extremely wasteful in production!

erulabs commented 1 year ago

I think I'd be more in favor of just simply allowing the user to define their own resources, with a default in the values.yaml, similar to how, eg, the haproxy helm chart operates on "resources".

Let me know and I can swap it to that pattern!

nepalez commented 1 year ago

Cute fix, thank you!

nepalez commented 1 year ago

Released in v0.8.33