search

imgproxy / imgproxy

Fast and secure standalone server for resizing and converting remote images
https://imgproxy.net
MIT License
8.8k stars 629 forks source link

Only first 10 parameters are pulled from AWS parameter store #1252

Closed felixmeziere closed 6 months ago

felixmeziere commented 6 months ago

Hi!

I just completed the AWS SAM setup to deploy imgproxy to lambda. This setup (and your product) are genius and are going to divide our costs by gazilions, thank you so much!

One issue I'm encountering in the setup: I'm using AWS systems manager parameter store (which is the default setup of your SAM template) to store the environment variables (and share them with my local imgproxy) and after some debugging I realised imgproxy only uses the first 10 parameters of the store (I have 18 related to imgproxy config).

After checking imgproxy's code I can confirm that the code of imgproxy uses GetParametersByPath (documented here), which only returns 10 results. To get the next results, it's necessary to do another call with pagination.

Is it possible to fix this problem or should we just document it and I move to using aws secrets manager?

DarthSim commented 6 months ago

Hey @felixmeziere!

Thanks for the report! Fixed in the latest build

felixmeziere commented 6 months ago

You're so responsive, thanks, amazing!

DarthSim commented 6 months ago

It was an easy fix, no problem