search

imguolao / monaco-vue

Use monaco-editor loaded from CDN in Vue 2&3, no need to bundling.
https://imguolao.github.io/monaco-vue/
MIT License
235 stars 21 forks source link

fix: editor are rendered multiple times #4

Closed qq1037305420 closed 2 years ago

qq1037305420 commented 2 years ago

editor are rendered multiple times for some reason, but only one instance is needed

qq1037305420 commented 2 years ago

具体什么原因导致的目前还没发现，这么改一下就可以了不过。 结合了第三方的响应式使用，导致了频繁渲染或者生命周期不符合

imguolao commented 2 years ago

https://github.com/imguolao/monaco-vue/blob/5e54ad4456f8b71341f58ef7ab194920e703b3b8/src/components/editor/Editor.tsx#L109-L116

应该是这里的 watchEffect 没有被及时 stop 导致重复触发 createEditor，我有空改一下这里的 watch once 实现吧。

新包已经发布了，thanks for your pr!