Add option to provide a session to the web client

[psavery]

We would like to create the requests.Session object on our own and pass it into WsiDicomWebClient, since we are not using an object derived from AuthBase to create it.

This PR adds support to pass a session to WsiDicomWebClient directly.

[erikogabrielsson]

Hi @psavery and thanks for the PR.

This is a reasonable change. Would you also like to add a Changed entry to CHANGELOG.md describing the change?

[psavery]

Hi @psavery and thanks for the PR.

This is a reasonable change. Would you also like to add a Changed entry to CHANGELOG.md describing the change?

Done!

[psavery]

FYI, there are other optional arguments on the DICOMwebClient __init__ method. See here.

In the future, if we keep needing to add arguments, we might want to consider just having the caller create the DICOMwebClient on their own and pass it in as an argument.

[erikogabrielsson]

FYI, there are other optional arguments on the DICOMwebClient __init__ method. See here.

In the future, if we keep needing to add arguments, we might want to consider just having the caller create the DICOMwebClient on their own and pass it in as an argument.

I agree, it would be good if WsiDicomWebClient init took a DICOMwebClient client. If you want, you can implement this and move the current init to a create-classmethod.

[psavery]

I agree, it would be good if WsiDicomWebClient init took a DICOMwebClient client. If you want, you can implement this and move the current init to a create-classmethod.

Done! Let me know what you think

[erikogabrielsson]

Looks good. Two things i forgot:

• The WsiDicomFileClient is only useful for testing. Now that the WsiDicomWebClient takes a DICOMwebClient we can remove this sub-class and instead use:

  client = WsiDicomWebClient(
  DICOMfileClient(f"file://{folder.absolute().as_posix()}")
  )

  in tests\conftest.py

• The section ***Or load a WSI dataset from DICOMWeb.*** in the readme needs to be updated.

[psavery]

Done. Let me know what you think.

[erikogabrielsson]

Great work. Thanks! I will merge this as soon as the checks runs OK.

[psavery]

@erikogabrielsson Let me know when you are planning to have another release of wsidicom so we can access these features on PyPI.

[erikogabrielsson]

@psavery Release 0.13..0 includes these changes. Thanks again for the contribution.

[psavery]

Thanks @erikogabrielsson!