search

imi-bigpicture / wsidicom

Python package for reading DICOM WSI file sets.
Apache License 2.0
33 stars 5 forks source link

Support combining multiple series for DICOMweb #118

Closed psavery closed 11 months ago

psavery commented 11 months ago

Similar to how the WsiDicomFileSource supports being provided multiple files, does it make sense to also allow multiple study_uids/ series_uids for the WsiDicomWebSource?

For this example, for instance, there are many optical paths, and most of the optical paths are located in separate series. It would be nice if we could instantiate a WsiDicomWebSource that contains all of these optical paths.

I would be happy to put up a PR for this if you think it sounds like a good idea.

erikogabrielsson commented 11 months ago

Allowing loading multiple series sounds good. Im not so sure about multiple studies. Is there a use-case for that? It will make patient and study level metadata for the wsi much more complicated.

Note that WsiDicomFileSource considers instances to be part of the pyramid if they have same study, series, and frame of reference uid. This is to strict, it should be enough that the frame of reference matches*. So if you implement this, please add a check that the obtained instances have the same frame of reference.

psavery commented 11 months ago

Allowing loading multiple series sounds good. Im not so sure about multiple studies. Is there a use-case for that? It will make patient and study level metadata for the wsi much more complicated.

No, I don't actually have an example that requires multiple studies, just multiple series, so we can go with that!

Note that WsiDicomFileSource considers instances to be part of the pyramid if they have same study, series, and frame of reference uid. This is to strict, it should be enough that the frame of reference matches*. So if you implement this, please add a check that the obtained instances have the same frame of reference.

Sounds good.

  • Ideally we should also check that the TotalPixelMatrixOriginSequence is the same, as there might be multiple pyramids on the same slide (i.e. frame of reference). It might also be worth implementing support for multiple pyramids.

Sounds good also!