imi-bigpicture / wsidicom

Python package for reading DICOM WSI file sets.
Apache License 2.0
32 stars 5 forks source link

wsidicom is quite strict in accepting DICOM #32

Closed GeertLitjens closed 2 years ago

GeertLitjens commented 2 years ago

DICOM files generated by, for example, https://github.com/GoogleCloudPlatform/wsi-to-dicom-converter are not accepted by wsidicom due to missing tags (e.g. OpticalPath-related), but can be opened by Orthanc. Maybe adding a flag --strict would be better? If you can read tags and the actual image data I think that should be enough to be acceptable.

erikogabrielsson commented 2 years ago

Thanks for the feedback @GeertLitjens. The OpticalPathSequence is currently checked to filter out non-standard files and is then parsed on two locations:

There are other properties that should be set to default values if not set in the files.

GeertLitjens commented 2 years ago

Maybe good to know: the Orthanc converter by default does not add a FrameOfReferenceUID and no ImageType (all images are considered VOLUME by default). Might be worthwhile to consider supporting that still with a warning?