Update to support requirements in DICOM standard 2022a

JamesDarcy616 commented 2 years ago

Tested on Hamamatsu NDPI images. Should improve DICOM compliance.

PhotometricInterpretation - YBR_FULL_422 for lossy standard JPEG, determine from encoder
ImagedVolumeDepth - must not be 0, supply default
WholeSlideMicroscopyImageFrameTypeSequence - required shared group, clone ImageType
LossyImageCompression and related - required for lossy JPEG
ImageType - typo in defined term
SeriesNumber - required, supply default
PositionReferenceIndicator - required, has defined term
[XY]OffsetInSlideCoordinateSystem - required
AcquisitionDateTime - required, supply default
IssuerOfTheContainerIdentifierSequence - required
Various typos e.g. "Unkown"

erikogabrielsson commented 2 years ago

Thanks for the pull request @JamesDarcy616! It looks like it will fix a lot of requirement that I have missed or not implemented. I will review this as soon as possible.

erikogabrielsson commented 2 years ago

Hi @JamesDarcy616, I merged some changes by mistake to your branch. Im sorry for that and will try to revert.

JamesDarcy616 commented 2 years ago

Great, thanks :)

erikogabrielsson commented 2 years ago

Thanks for contributing James! I have just published 0.2.0 with these changes.

imi-bigpicture / wsidicomizer

Update to support requirements in DICOM standard 2022a #20