imightbeamy / gcal-multical-event-merge

Browser extension that visually merges the same event on multiple Google Calendars into one event.
GNU General Public License v3.0
250 stars 56 forks source link

Event is hidden when in same time-slot as a merged event #60

Open ericslandry opened 6 years ago

ericslandry commented 6 years ago

An event in my main calendar is hidden when in same time-slot as a merged event.

Event A is reoccurring (5-6 pm multiple days every week) and shared with calendar Foo Event B is once and is in same time-slot as Event A (5-6 pm)

When I deselect (hide) calendar Foo, I see both events. When I select (show) calendar Foo, I only see the reoccurring event.

I was not able to reproduce in another time-slot with different events. Should I try anything else?

Event Merge 2.1.2 Chromium Version 64.0.3282.167 (Official Build) Built on Ubuntu , running on Ubuntu 16.04 (64-bit) Xubuntu 16.04

asolverson commented 6 years ago

I ran into this same problem.

Event A is a recurring event (11am-12pm every Tuesday) with 10 invitees. Event B occurs once at the same time as Event A and has 6 invitees.

I had this problem when I first created event B. When I tried to view calendars of multiple invitees for event A and only one calendar for event B, event B was completely hidden. When viewing only one calendar for each event, both events were visible.

The issue has now resolved itself, but I don't know why or how. I have not been able to recreate it.

Event Merge 2.1.2 Chrome Version 67.0.3396.62 (Official Build) (64-bit) Windows 10 Pro

evansiroky commented 6 years ago

I'm also seeing this. Looking at the code, I think the issue is the calculation of the positions of various events: https://github.com/imightbeamy/gcal-multical-event-merge/blob/master/events.user.js#L58-L66

screen shot 2018-06-22 at 1 28 57 pm

In my case there are 2 events at the same time where one of them has 2 people attending and the other has 5 people attending. It appears that the code correctly divided up which events should be grouped with the other, but unfortunately the positions of each event as they are initially rendered are not horizontally grouped together. Therefore, one of my events takes up the full width and completely overlaps the other one that doesn't take up the full width of the day column.

Maybe it would be possible to check other event sets to see if they have the same time span and then customize the width of the grouped events in the output?

leoherzog commented 6 years ago

We are also seeing this issue in our organization. Anything we can do to test a fix, let us know!

imightbeamy commented 5 years ago

Sorry for the delay here, I only get around to these issues every once in a while. @evansiroky's analysis seems correct! If I recall, the calculation assumes the events are grouped together. When I have a chance I'll see about other ways to determine position for these cases 🤔

m60freeman commented 5 years ago

I just started using this [version 2.1.3 on Chrome Version 72.0.3626.96 (Official Build) (64-bit)] and immediately noticed what is a related inconsistency:

image

Note that on the 20th, "Janet work" is in front of the merged event (making that description mostly hidden - note that I blacked out a partially visible address in the image), but on the 21st, "Gym" is appropriately in front of the other two overlapping events.

jbergstroem commented 5 years ago

~Here's a pretty clear proof of concept of this summarized in two images; 4 people invited to a morning standup (same event), two of the events gets truncated:~

Screen Shot 2019-06-06 at 9 29 05 AM Screen Shot 2019-06-06 at 9 29 09 AM

Edit: nope, this is obviously something completely different. Apologies for the noise.

confluence commented 6 months ago

This is still affecting me today. I can't ever put another event in the exact same slot as a merged event.