search

iminurnamez / pyroller

pygame casino
65 stars 29 forks source link

Some Blackjack work #10

Closed martinbarnard closed 9 years ago

martinbarnard commented 9 years ago
jellyberg commented 9 years ago

Mek: to fix the issue with the json file, maybe we should add that filetype to the gitignore?

Mekire commented 9 years ago

That would probably be the easiest.

martinbarnard commented 9 years ago

Done and done. Do I need to create a new pull request each time?

iminurnamez commented 9 years ago

I'm missing the point of the lobby button on the title screen. Can you clarify a bit?

As to rebuys, I'd like to get some input on how we should handle the player running out of funds before implementing this. I'm not sure the stats menu would be the best place anyway.

martinbarnard commented 9 years ago

When testing the blackjack game, I was running out of cash and having to quit/restart to continue testing. The lobby & rebuy buttons allow you to top your funds back up and get back into the game without quitting/restarting.

It was placed in the stats menu, as it was the one easiest to modify. No reason to not shift it elsewhere, like the lobby.

I was thinking about working on adding card totals, and other information to the blackjack interface. I'll contact the blackjack maintainer and discuss it with him, assuming no objections?

Martin

On 17 December 2014 at 21:20, iminurnamez notifications@github.com wrote:

I'm missing the point of the lobby button on the title screen. Can you clarify a bit?

As to rebuys, I'd like to get some input on how we should handle the player running out of funds before implementing this. I'm not sure the stats menu would be the best place anyway.

— Reply to this email directly or view it on GitHub https://github.com/iminurnamez/pyroller/pull/10#issuecomment-67376919.

martinbarnard commented 9 years ago

...which is you :)

On 17 December 2014 at 21:54, Martin Barnard barnard.martin@gmail.com wrote:

When testing the blackjack game, I was running out of cash and having to quit/restart to continue testing. The lobby & rebuy buttons allow you to top your funds back up and get back into the game without quitting/restarting.

It was placed in the stats menu, as it was the one easiest to modify. No reason to not shift it elsewhere, like the lobby.

I was thinking about working on adding card totals, and other information to the blackjack interface. I'll contact the blackjack maintainer and discuss it with him, assuming no objections?

Martin

On 17 December 2014 at 21:20, iminurnamez notifications@github.com wrote:

I'm missing the point of the lobby button on the title screen. Can you clarify a bit?

As to rebuys, I'd like to get some input on how we should handle the player running out of funds before implementing this. I'm not sure the stats menu would be the best place anyway.

— Reply to this email directly or view it on GitHub https://github.com/iminurnamez/pyroller/pull/10#issuecomment-67376919.

iminurnamez commented 9 years ago

I still don't follow on the lobby button. The only way to end up on the title screen is by restarting anyway so it seems like it just duplicates the functionality of the load game button.

Regarding the blackjack interface: Yup, that's me :) Shoot me a message on reddit and let me know what you have in mind.

paulpaterson commented 9 years ago

On the question of rebuys it is interesting to ask: what (valuable) thing will the player exchange to get more additional funds? Time (limited rebuys per hour ...)? Prestige (surrender levels or XP you have gained ...)?

Probably a nice question for the reddit group!

martinbarnard commented 9 years ago

I'm still unable to start a new game without quitting. There is no option to reset your cash, as you cannot do it from the lobby. Perhaps you could look at a button on the lobby to take you back to title screen?

On 18 December 2014 at 05:28, iminurnamez notifications@github.com wrote:

Closed #10 https://github.com/iminurnamez/pyroller/pull/10.

— Reply to this email directly or view it on GitHub https://github.com/iminurnamez/pyroller/pull/10#event-209365466.

iminurnamez commented 9 years ago

Resetting cash is still being discussed. In the meantime, you can change the player's initial cash (in casino_player) to make testing easier.

metulburr commented 9 years ago

for testing, if the problem is running out of money....You could add a flag here to set money to something ridiculously high, or code it to be unlimited. Set that to prepare.MONEY. Then import prepare into here to use prepare.MONEY instead of an arbitrary number. Then you can add the flag python pyroller.py -M 1000000 to give yourself a million to test with.

Or if the -M flag, allow a cheater button to popup to add cash to your money to continue testing.