search

imixs / imixs-workflow

The open source technology for business process management
http://www.imixs.org/
GNU General Public License v3.0
358 stars 64 forks source link

Refactored to fix 3 implementation smells #855

Closed ashishbhasin45 closed 7 months ago

ashishbhasin45 commented 7 months ago

  1. Decompose complex conditional. Location- Sub-project: imixs-workflow-core Package: org.imixs.workflow.xml class: XMLItem Method: stripNonValidXMLCharacters

  2. Renamed the variable in the specified method from o to a currentReportItemValue for better understandability. Location- Sub-project: imixs-workflow-engine Package: org.imixs.workflow.engine Class: ReportService Method: updateReport

  3. Decomposed parseTag method to resolve a complex method code smell for readability and understandability. Location- Sub-project: imixs-workflow-core Package: org.imixs.workflow.util class: XMLParser Method: parseTag