Closed rsoika closed 7 months ago
Because of a problem with circular dependencies as discussed here we implemented a workaround with a custom ActionDispatcherFactory.
Changes in di.config.ts can be removed :
bind(ActionDispatcherFactory).toFactory<GLSPActionDispatcher>( ctx => () => ctx.container.get<GLSPActionDispatcher>(TYPES.IActionDispatcher) );
and in the bpmn-select-listeners.txs module we can fall back to the normal injection and calling the ActionDispatcher
ActionDispatcher
@inject(TYPES.IActionDispatcher) protected actionDispatcher: ActionDispatcher; ... // finally dispatch the updated selected and unselected IDs... // this.actionDispatcher.dispatch(SelectAction.create({ selectedElementsIDs: selectedElements, deselectedElementsIDs: containerIDs }));
async method updateSelectionData is no longer needed if the bug is solved.
async
updateSelectionData
Things become better. But still not all issues solved.
Panel is not rendered. Seems to be a minor issue with the init of the UIExtension....
Because of a problem with circular dependencies as discussed here we implemented a workaround with a custom ActionDispatcherFactory.
Changes in di.config.ts can be removed :
and in the bpmn-select-listeners.txs module we can fall back to the normal injection and calling the
ActionDispatcher
async
methodupdateSelectionData
is no longer needed if the bug is solved.