Alternative Godot 4 port

[farfalk]

Godot 4 port, fully functional (afaik) and currently updated to Godot 4 beta 2. Alternative candidate at closing https://github.com/imjp94/gd-YAFSM/issues/46.

I'm using this addon in a project of mine. At the start I was using the port by @adamscott (https://github.com/imjp94/gd-YAFSM/pull/47) , but the list of corrections I had to make during the development to make it functional (most of all, the real time debugging part) has grown too big to just report them all in the discussion.

Should be at feature parity, with only a small aesthetic addition: during a transition, the conditions of the transition are highlighted as well.

Feel free to test this version, merge it in adamscott's proposal, or use it instead!

(thanks a lot to @adamscott for the initial work!)

[farfalk]

I realize my latest addition is a bit off-scope for a "port to Godot 4.0" pull request. The zoom/scaling handling with snapping was very broken with 4.0 though, so I think the changes I made are sensible. Let me know how to proceed otherwise.

[imjp94]

It's ok, I think it is absolutely fine to include some minor fix directly into the port. Thanks for the contribution!

[imjp94]

Since Godot-4.0 stable has been released, I am preparing to merge 4.0 branch to master as well. I tested it and found some minor issues:

• [x] Default state name's index is random. Newly added state should looks like this: State1, State2 and State3
• [x] Missing default condition name. There should be a default name for newly added condition
• [x] Nested state shape doesn't revert to normal state shape. Empty nested state is still a hard corner rectangle instead of round corner rectangle. This happens when double click on a state but go back without adding any state into it.

It should be ready to merge after resolving the issues. Great job!

[farfalk]

Thanks for the review! I should be able to work on it in the next few days.

[farfalk]

@adamscott I had to revert the last parameter of the draw_line function to true in FlowChartGrid.gd because I was experiencing heavy graphic glitches during zoom operations in my secondary monitor.

[farfalk]

@imjp94 should have solved all of your points! Let me know

[imjp94]

@farfalk Thank you! It's almost there!

• Can you make the default condition name as "Param" and indexed like the state name? For example, "Param", "Param1", "Param2", etc. So it make sense to call StateMachine.set_param in code. Sorry that I didn't make it clear in the last comment. Godot 3.x(Expected behavior)

• And nested state shape doesn't revert to normal state shape. Godot 3.x(Expected behavior) Godot 4.x

[farfalk]

@imjp94 I'll work on the first point asap. For the second, it's a bit strange: on my part it never happens after commit 7715c1c. I'll think about it

[farfalk]

@imjp94 fixed both, I think. Check it out :)

[imjp94]

@farfalk Perfect! Thank you so much!