timothy1ee
commented
10 years ago Imju, sorry for the delayed review.
- You don't have any Auto Layout constraints. It takes practice to work with Auto Layout, you should try it.
- In TweetCell, use UILabel, not UITextView for non-editable text.
The main takeaways for this homework were:
- How to handle dynamically sized rows in table views.
- How to implement and debug Auto Layout in the Tweet Cell, Compose view, and Tweet view.
- How to implement nav stack and modal navigation.
- How to augment a networking client.
- How to augment a model, adding serialization/deserialization code, and formatting code.
Here's my checklist of things I'm looking at when I'm reviewing this project.
- Is the Objective-C code styling consistent with standards?
- Did you augment the API client with the methods for updating status, reply, retweet, favorite? Note that there is a separate endpoint for removing a retweet or favorite.
- Did you augment the Tweet model? Note that for the embedded user, you should instantiate a User object and have the User class do the deserialization, instead of navigating to user.screen_name in the Tweet model.
- Were the Auto Layout constraints correct for all the views?
- Was the navigation implemented correctly either manually or via segues?
- Was pull to refresh implemented?
- Was infinite scrolling implemented?
/cc @timothy1ee
Hi Tim,
I finished the project. I still need to polish UI and need some minor adjustment but basic functionality is working. I didn't pay attention to ui or layout. I will try it out after looking at group project.
Instruction In order to complete the tweet, in compose screen, please click 'Tweet' then alert will ask for action. For retweet, favorite, there is no visual response. I may need to change the icon so to show the status.
One issue, haven't tested where it goes back to after reply, timeline view or twit view? I don't know. Honestly I was just happy to see that composer came up. It should be able to update. I will check it out later.
No bonus implementation. Thanks! Imju