imker25 / samba_exporter

A Prometheus exporter for statistic data of the samba file server.
https://imker25.github.io/samba_exporter/
Apache License 2.0
30 stars 6 forks source link

Use more abstract logging #128

Closed imker25 closed 7 months ago

imker25 commented 8 months ago

The logging is done in a very direct approach where log messages are written to console in the commonbl/logger module. There is no abstraction with interfaces, and so the logger can not be replaced.

This is a problem especial for unit tests, since they have to use the real console and can not mock the logger instance.

Having a interface to abstract the logger, may also makes the implementation of future features a little faster in the long run.

imker25 commented 7 months ago

Fix released with V1.32.9