search

imkira / mobiledevice

Command line utility for interacting with Apple's Private (Closed) Mobile Device Framework
MIT License
672 stars 135 forks source link

simplify mobiledevice.c -> rename to mobiledevice.m and use NSSttring instead of CFString and ARC #5

Closed leopatras closed 9 years ago

leopatras commented 9 years ago

saves about 100 lines of code and makes string deallocation a bit more safe

leopatras commented 9 years ago

I didn't touch the Rakefile as I don't have any clue about how they work. But calling make from the Rakefile shouldn't be too hard:-)

imkira commented 9 years ago

Thanks for the PR! Please allow me to comment some parts of the code as above. Let me know what you think.

leopatras commented 9 years ago

Hi Mario, glad you did look into the pull request. I think all your comments make sense and it’s no problem to incorporate that . If you already did the changes , feel free to apply them. Regards, Leo

On 20.10.2014, at 08:38, Mário Freitas notifications@github.com wrote:

Thanks for the PR! Please allow me to comment some parts of the code as above. Let me know what you think.

— Reply to this email directly or view it on GitHub.

imkira commented 9 years ago

Hi, @leopatras I haven't change any code here. I was hoping you could incorporate the changes by committing to leopatras:master I could then merge them into the main repo.

Regards, Mario

leopatras commented 9 years ago

Ok, I will make the changes (probably tomorrow) and come back to you when I’m ready. Thank you , Leo

On 20.10.2014, at 11:12, Mário Freitas notifications@github.com wrote:

Hi, @leopatras I haven't change any code here. I was hoping you could incorporate the changes by committing to leopatras:master I could then merge them into the main repo.

Regards, Mario

— Reply to this email directly or view it on GitHub.

imkira commented 9 years ago

It looks good to me! Thanks for contributing!