search

imknown / AndroidLowLevelDetector

Detect Treble, GSI, Mainline, APEX, system-as-root(SAR), A/B, etc.
https://github.com/imknown/AndroidLowLevelDetector
Apache License 2.0
247 stars 18 forks source link

AndroidLowLevelDetector: Add Chinese(Traditional) Translate #6

Closed bluehomewu closed 2 years ago

bluehomewu commented 2 years ago

Signed-off-by: Edward Wu bluehome.wu@gmail.com

Please fix Chinese(Traditional) translator name (My name) on Line 193 ~ Line 195

I'm not sure how would you modify it, so I only left my name, didn't modified strings name. Thank you!

imknown commented 2 years ago

Hi, thank you very much for your Pull Request. 😸 I have reviewed this PR, and all are OK.

But after checking this, I find something wrong in zh-rCH, such as \u0020, which should be used for Indo-European languages (English, French, Etc.). So no need to add it for CJK languages, I think. I have corrected them in https://github.com/imknown/AndroidLowLevelDetector/commit/a4bbbaefa1e37d96acce69e7335513bdf9afaaca.

So, I will merge this PR and, likewise, I will correct them later myself. Is that OK?

By the way, translator info format can be like:

    <string name="translation_language_and_translator">繁體中文（臺灣），翻譯：bluehomewu</string>
    <string name="translator_website"><HERE YOUR WEBSITE></string>
    <string name="translator_more_info">https://github.com/bluehomewu</string>

Thank you again for your translation. 😺

bluehomewu commented 2 years ago

Hi, thank you very much for your Pull Request. 😸 I have reviewed this PR, and all are OK.

But after checking this, I find something wrong in zh-rCH, such as \u0020, which should be used for Indo-European languages (English, French, Etc.). So no need to add it for CJK languages, I think. I have corrected them in a4bbbae.

So, I will merge this PR and, likewise, I will correct them later myself. Is that OK?

By the way, translator info format can be like:

    <string name="translation_language_and_translator">繁體中文（臺灣），翻譯：bluehomewu</string>
    <string name="translator_website"><HERE YOUR WEBSITE></string>
    <string name="translator_more_info">https://github.com/bluehomewu</string>

Thank you again for your translation. 😺

I don't have a personal website, so second one please point to my GitHub page too. Thanks.

imknown commented 2 years ago

Merged and modified here.

bluehomewu commented 2 years ago

Merged and modified here.

Thanks for help.