immadisairaj / CodeforcesApp

An android application which uses Codeforces Api.
Apache License 2.0
15 stars 7 forks source link

feat: add landscape capability #11

Closed adarshsiva closed 5 years ago

adarshsiva commented 5 years ago

Fixed: #7

Changes:

Added landscape compatibility.

Screenshots: Landscape: Webp net-resizeimage (1) Webp net-resizeimage (3)

Webp net-resizeimage (4) Portrait: Webp net-resizeimage (7)

Webp net-resizeimage (6)

Webp net-resizeimage (5)

immadisairaj commented 5 years ago

@adarshsiva please follow semantic PR guidelines. https://github.com/commitizen/conventional-commit-types/blob/master/index.json

immadisairaj commented 5 years ago

@adarshsiva can you also add the screenshot of the activity you've changed and also in landscape mode

immadisairaj commented 5 years ago

@adarshsiva the title should be feat: add landscape capability

immadisairaj commented 5 years ago

@adarshsiva don't remove the pr template in the comment. You add screenshot along with the template given.

immadisairaj commented 5 years ago

It has to be in that format. https://github.com/commitizen/conventional-commit-types/blob/master/index.json this link is doc for what kind of pr. If it is bug you write fix: and if it is feature you write feat: and so on

adarshsiva commented 5 years ago

@immadisairaj please review

immadisairaj commented 5 years ago

@adarshsiva, when I rotate my phone to landscape or portrait mode in info activity the whole, is loading again. Instead it should load and load again and use the already stored value.

immadisairaj commented 5 years ago

also can make the grid to 3 when in landscape in submissions

when I rotate my phone to landscape or portrait mode in info activity the whole, is loading again. Instead it should load and load again and use the already stored value.

same thing is applicable in submission activity also

Edit: I think the UI is not soo good and optimised. if you can improve it then you can do that also.

adarshsiva commented 5 years ago

Requested Changes have been made.

immadisairaj commented 5 years ago

@adarshsiva can you update the screenshots and also add gif if possible

Edit: both in portrait and landscape

immadisairaj commented 5 years ago

@adarshsiva can you resolve the conflicts

adarshsiva commented 5 years ago

I'll update and revert back.

immadisairaj commented 5 years ago

I'll update and revert back.

don't revert. just resolve

adarshsiva commented 5 years ago

Screenshots have been added.