Closed adarshsiva closed 5 years ago
@adarshsiva please follow semantic PR guidelines. https://github.com/commitizen/conventional-commit-types/blob/master/index.json
@adarshsiva can you also add the screenshot of the activity you've changed and also in landscape mode
@adarshsiva the title should be
feat: add landscape capability
@adarshsiva don't remove the pr template in the comment. You add screenshot along with the template given.
It has to be in that format.
https://github.com/commitizen/conventional-commit-types/blob/master/index.json
this link is doc for what kind of pr. If it is bug you write fix:
and if it is feature you write feat:
and so on
@immadisairaj please review
@adarshsiva, when I rotate my phone to landscape or portrait mode in info activity the whole, is loading again. Instead it should load and load again and use the already stored value.
also can make the grid to 3 when in landscape in submissions
when I rotate my phone to landscape or portrait mode in info activity the whole, is loading again. Instead it should load and load again and use the already stored value.
same thing is applicable in submission activity also
Edit: I think the UI is not soo good and optimised. if you can improve it then you can do that also.
Requested Changes have been made.
@adarshsiva can you update the screenshots and also add gif if possible
Edit: both in portrait and landscape
@adarshsiva can you resolve the conflicts
I'll update and revert back.
I'll update and revert back.
don't revert. just resolve
Screenshots have been added.
Fixed: #7
Changes:
Added landscape compatibility.
Screenshots: Landscape:
Portrait: