search

immadisairaj / CodeforcesApp

An android application which uses Codeforces Api.
Apache License 2.0
15 stars 7 forks source link

chore: Use dimensions from dimen resources. #14

Closed abhijitramesh closed 5 years ago

abhijitramesh commented 5 years ago

Describe the feature you'd like Currently, the xml files are using hardcoded dimensions. Store those dimensions in the dimens resource files and use them from there.

aman-g0yaa commented 5 years ago

can I solve this issue ?

aman-g0yaa commented 5 years ago

when I opened the project in android studio error was shown that new version of build gradle was available. how should i fix it? should I make a issue to fix the errors?

aman-g0yaa commented 5 years ago

I have fixed this issue , unfortunately some file named idea was added which I think is unnecessary. I will fix it and send pr tomorrow.

immadisairaj commented 5 years ago

when I opened the project in android studio error was shown that new version of build gradle was available. how should i fix it? should I make a issue to fix the errors?

@amangoyal2339 this conversation is only related to particular issue. These kind of discussions should be done in gutter channel.