fix: Add rating button - Githubissues

immadisairaj / CodeforcesApp

An android application which uses Codeforces Api.

Apache License 2.0

15 stars 7 forks source link

fix: Add rating button #24

Closed abhinandhari closed 5 years ago

abhinandhari commented 5 years ago

Fixes #5 #6

Changes:

Implemented Rating function, tweaked UI.

Please make sure these boxes are checked before submitting your pull request - thank you!

[x] Run unit tests with ./gradlew check to make sure you didn't break anything
[x] If you have multiple commits please combine them into a single commit by squashing them.

immadisairaj commented 5 years ago

@abhinandhari I don't feel the UI is improved. You can do #5 in a new PR.

immadisairaj commented 5 years ago

I feel the user.rating button can be inside the info activity and direct it to a rating activity which shows all the contests and ratings using recycler view

immadisairaj commented 5 years ago

@abhinandhari and also don't try to make a multiple PR's for one issue