immadisairaj / CodeforcesApp

An android application which uses Codeforces Api.
Apache License 2.0
15 stars 7 forks source link

chore : Add Screenshots to Readme.md #26

Closed aman-g0yaa closed 5 years ago

aman-g0yaa commented 5 years ago

Fixes #18 Changes: Added 3 screenshots into READ.md file.

Please make sure these boxes are checked before submitting your pull request - thank you!

Please add screenshots/GIFs here if there are any changes to the UI below.

immadisairaj commented 5 years ago

@amangoyal2339 why did you close the old PR. this is not a good practice.

Please follow semantic PR guidelines

aman-g0yaa commented 5 years ago

@immadisairaj Sorry , I wont repeat it .

immadisairaj commented 5 years ago

@amangoyal2339 change the title and commit to add instead of added follow semantic PR guidelines

immadisairaj commented 5 years ago

Run unit tests with ./gradlew check to make sure you didn't break anything
If you have multiple commits please combine them into a single commit by squashing them.

and also make sure you do this