immanuelfodor / shaarli-markdown-toolbar

Shaarli plugin to easily insert markdown syntax into the Description field when editing a link
https://github.com/shaarli/Shaarli
MIT License
17 stars 0 forks source link

jQuery is undefined #1

Closed ArthurHoaro closed 6 years ago

ArthurHoaro commented 6 years ago

I have this issue on both Firefox and Chrome, tested on Shaarli master and v0.9.2, with only markdown and markdown-toolbar enabled. jQuery doesn't seem to load properly... but the jQuery JS itself is loaded in the network tab.

screenshot_20180101_153411

immanuelfodor commented 6 years ago

It seems the emojione plugin added a secondary jQuery to the page that is why it worked for me and not for you. I saw the second jQuery version before this is why I used jQuery.noConflict() in the beginning of my plugin's JS but I have forgotten to check the dependency JS file. Now it uses my jQuery version, too. Please check it now, it should work, I managed to reproduce your error and it is fixed by the last commit on my instance.

ArthurHoaro commented 6 years ago

Yep, it works fine, well done 👍