immanuelfodor / shaarli-markdown-toolbar

Shaarli plugin to easily insert markdown syntax into the Description field when editing a link
https://github.com/shaarli/Shaarli
MIT License
17 stars 0 forks source link

Shaarli icon not shown in header and footer #5

Open bttrx opened 1 week ago

bttrx commented 1 week ago

Hi!

I'm using your latest toolbar and Shaarli 0.13.0. When your plugin is enabled, Shaarli's default theme doesn't show "the Shaarli star" icon, but a hieroglyph.

Header: grafik

Footer: grafik

Your FontAwesome is overwriting Shaarli's ForkAwesome: grafik

immanuelfodor commented 1 week ago

Oh, I'm sorry to hear it. I'm using the Material theme, so I never had this issue.

Could you please try commenting out or deleting this line in your plugin to see if it fixes the issue? https://github.com/immanuelfodor/shaarli-markdown-toolbar/blob/master/markdown_toolbar/markdown_toolbar.php#L80

bttrx commented 1 week ago

That worked for me indeed.

immanuelfodor commented 1 week ago

Hurray! :tada: I'll keep the issue open if somebody else runs into it, so they'll know of the workaround. Maybe a detection of the theme could solve it for the long term.