immanuelhume / pe

0 stars 0 forks source link

Diagram would be more effective than prose #12

Open immanuelhume opened 1 year ago

immanuelhume commented 1 year ago

In describing the design decisions behind the instantiation of a CommandBox, there was attention paid to a "single, bidirectional association". This would have been much more effective and easy to understand with a class and/or sequence diagram.

image.png

soc-se-bot commented 1 year ago

Team's Response

The diagrams that explain those have already been given in the previous sections, drawing it again will not add too much value. One possible diagram is CommandBox --- MainWindow --- Logic --- Model, but including more components will only dilute the main message, that there is no need for command box to interact with model directly.

This sentence alone serves the purpose well and clear.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thanks for explaining. I am disagreeing for the following reasons:

  1. I have looked at the class diagram above, and as far as I can see, it is showing a uni-directional relation between a MainWindow and a CommandBox. I have included a screenshot below. I could not find any diagram which references the role of the CommandExecutor.
  2. "This sentence alone serves the purpose well and clear." I feel the opposite - it is hardly clear to me. Why would the constructor taking a CommandExecutor lead to a bidirectional association between the "the two"? And which "two"? There are three classes mentioned in the previous sentence so it is not clear which pair is being referenced.
  3. A single UML diagram would have cleared all this vagueness.

image.png