immauss / openvas

Containers for running the Greenbone Vulnerability Manager. Run as a single container with all services or separate single applications containers via docker-compose.
GNU Affero General Public License v3.0
337 stars 97 forks source link

Redis #255

Closed rkoosaar closed 1 month ago

rkoosaar commented 4 months ago

I noticed that when redis starts up (when you start the single container), it gives the following warning.

93:M 25 Feb 2024 23:25:37.632 # WARNING Memory overcommit must be enabled! Without it, a background save or replication may fail under low memory condition. Being disabled, it can can also cause failures without low memory condition, see https://github.com/jemalloc/jemalloc/issues/1328. To fix this issue add 'vm.overcommit_memory = 1' to /etc/sysctl.conf and then reboot or run the command 'sysctl vm.overcommit_memory=1' for this to take effect.

Is this something that should be enabled?

immauss commented 3 months ago

Yes.... thought I've never had a problem with not enabling it. Since this is a kernel setting, It is something you would need to do on the host machine, it can not be handled via the container. ( I tried... )

-Scott

rkoosaar commented 3 months ago

My problem with redis - during the scans I get this:

HEALTHECHECK FAILED ! These services failed: redis

and in another log this comes up: "redis connection error to /run/redis/redis.sock: Connection refused"

And I cant work out yet why that happens.

immauss commented 2 months ago

Sorry for the delay ... But did you manage to work this out?

If not, can you please share more details about your setup and how you are starting the container.

Thanks, Scott

rkoosaar commented 2 months ago

No, I'm still troubleshooting this. Running debian 12 box. I have openvas single container running behind traefik.

I've added these to /etc/sysctl.conf: vm.overcommit_memory=1 net.core.somaxconn=16384

crash seems to happen when connection to redis seems to be lost. but I cant really tell why that is. It seems to happen during the scanning.

immauss commented 2 months ago

Traefik shouldn't even see the redis server .. so Hmmm Are you using any exotic storage options? Is there anything of value from the logs?

I've never really had (nor seen anyone else have) problems with redis before. Can you please share how you are starting the container? If via docker run, please provide full command. If via docker-compose, please provide the docker-compose.yml.

-Scott

immauss commented 2 months ago

Also, even though I don't think it has anything to do with traefik, take a look at this thread too. #184 There's some good info there on Traefik that I have not had time to incorporate into the docs.

rkoosaar commented 2 months ago

I may have fixed the issue. I'll see how it performs over the weekend. I have bunch of scans running then.

immauss commented 2 months ago

@rkoosaar That's great. Please let me know how it goes and if you can, how you managed to resolve the problem.

Thanks, Scott

immauss commented 2 months ago

Any updates @rkoosaar ?

rkoosaar commented 1 month ago

I'm not 100% sure it is working yet. I've been away on holiday and the machine thats running the container had some unexpected downtime.