search

immense / knockout-tinymce

TinyMCE binding for Knockout.js
http://rawgit.com/immense/knockout-tinymce/master/demo.html
MIT License
6 stars 4 forks source link

ability to bind to non-observable #7

Closed Manuel-S closed 8 years ago

Manuel-S commented 8 years ago

Implemented the way the standard knockout bindings update values, which also updates plain properties if they're not observable.

This is needed to use the binding with knockout-es5 properties.

cmbankester commented 8 years ago

Aside from the comment I left on knockout-tinymce.coffee, it looks good! Fix that up and I'll get it merged in.

Also: thanks for the nod to knockout-es5, I'd never seen that before

cmbankester commented 8 years ago

I found one issue while testing this: it seems to only work when using the debug version of knockout.js.

Manuel-S commented 8 years ago

Hm that's not good. My guess is the method is not exported in the min version, might have to copy it.

Manuel-S commented 8 years ago

Can you try again with this? Pulled a small utility function into the binding and used the exported member _twoWayBindings.

Manuel-S commented 8 years ago

Do you think this is ready to be merged?

Manuel-S commented 8 years ago

bump, waiting to integrate this into my project.

Manuel-S commented 8 years ago

chuck-norris