immers-space / activitypub-express

Modular ActivityPub implementation as Express JS middleware to easily add decentralization and federation to Node apps
MIT License
295 stars 22 forks source link

delivery: https://.../inbox 401 #92

Open LuckyCoders opened 1 year ago

LuckyCoders commented 1 year ago

https://github.com/immers-space/activitypub-express/blob/364d90705731dca755f3cb21747274eba0aad1e4/pub/federation.js#L124

result.statusCode == 401 Unauthorized response status code indicates that the client request has not been completed because it lacks valid authentication credentials for the requested resource.

wmurphyrd commented 1 year ago

The condition in the linked code is checking whether we should retry the delivery after failure. We would not want to retry a 401 because it would remain unauthorized in future attempts. Did you mean to link somwhere else?