immerse-project / wp6.2-demonstrator

MIT License
0 stars 0 forks source link

Comparison commit 1d52b13a and 9aad242d #41

Open github-actions[bot] opened 2 years ago

github-actions[bot] commented 2 years ago

Hi there, commit 1d52b13a has been pushed. Here is the comparison with the commit currently used.

⚠️WARNING⚠️ cfgs/SHARED/namelist_ref has changed:

diff ./nemo/cfgs/SHARED/namelist_ref ./head/cfgs/SHARED/namelist_ref
1540a1541,1554
>    ln_sto_ldf  = .false.   ! stochastic lateral diffusion
>    rn_ldf_std  =  0.1      ! lateral diffusion standard deviation (in percent)
>    rn_ldf_tcor =  1440.    ! lateral diffusion correlation timescale (in timesteps)
>    ln_sto_hpg  = .false.   ! stochastic pressure gradient
>    rn_hpg_std  =  0.1      ! density gradient standard deviation (in percent)
>    rn_hpg_tcor =  1440.    ! density gradient correlation timescale (in timesteps)
>    ln_sto_pstar  = .false. ! stochastic ice strength
>    rn_pstar_std  =  0.1    ! ice strength standard deviation (in percent)
>    rn_pstar_tcor =  1440.  ! ice strength correlation timescale (in timesteps)
>    nn_pstar_ord  =  1      ! order of autoregressive processes
>    nn_pstar_flt  =  0      ! passes of Laplacian filter
>    ln_sto_trd  = .false.   ! stochastic model trend
>    rn_trd_std  =  0.1      ! trend standard deviation (in percent)
>    rn_trd_tcor =  1440.    ! trend correlation timescale (in timesteps)
1548a1563,1570
>    ln_sto_trc  = .false.   ! stochastic tracer dynamics
>    nn_sto_trc  = 1         ! number of independent random walks
>    rn_trc_stdxy = 1.4      ! random walk horz. standard deviation (in grid points)
>    rn_trc_stdz = 0.7       ! random walk vert. standard deviation (in grid points)
>    rn_trc_tcor = 1440.     ! random walk time correlation (in timesteps)
>    nn_trc_ord  = 1         ! order of autoregressive processes
>    nn_trc_flt  = 0         ! passes of Laplacian filter
>    rn_trc_lim  = 3.0       ! limitation factor (default = 3.0)
atb299 commented 2 years ago

There are changes to src/NST/agrif_oce_interp.F90, src/NST/agrif_oce_sponge.F90, src/NST/agrif_top_interp.F90, src/NST/agrif_top_sponge.F90 of the form:

- DO jk=k1,k2 + DO jk=k1,k2-1

All other changes look OK (to me), but may need to check the behaviour of AGRIF carefully.

atb299 commented 2 years ago

As of today, I am now getting this error:

Program received signal SIGABRT: Process abort signal.

Backtrace for this error: In file "xml_parser_impl.hpp", function "static void xios::xml::CXMLParser::ParseInclude(StdIStream&, const string&, T&) [with T = xios::CGroupTemplate<xios::CFile, xios::CFileGroup, xios::CFileAttributes>; StdIStream = std::basic_istream<char>; std::string = std::__cxx11::basic_string<char>]", line 38 -> Error is occuring when parsing XML flux from <./file_def_nemo-ice.xml> at character 2719 line 56 column 1

ÿ ^

No idea why this has changed... there is no 'ÿ' in that file or the -oce.xml. I tried a fresh checkout and get the same error.

jdha commented 2 years ago

There are changes to src/NST/agrif_oce_interp.F90, src/NST/agrif_oce_sponge.F90, src/NST/agrif_top_interp.F90, src/NST/agrif_top_sponge.F90 of the form:

- DO jk=k1,k2 + DO jk=k1,k2-1

All other changes look OK (to me), but may need to check the behaviour of AGRIF carefully.

@atb299 it's in the outer halo - so should be ok. I've run it for the Caribbean and looks ok. Original ticket is here: https://forge.nemo-ocean.eu/nemo/nemo/-/issues/20

jdha commented 2 years ago

As of today, I am now getting this error:

Program received signal SIGABRT: Process abort signal.

Backtrace for this error: In file "xml_parser_impl.hpp", function "static void xios::xml::CXMLParser::ParseInclude(StdIStream&, const string&, T&) [with T = xios::CGroupTemplate<xios::CFile, xios::CFileGroup, xios::CFileAttributes>; StdIStream = std::basic_istream<char>; std::string = std::__cxx11::basic_string<char>]", line 38 -> Error is occuring when parsing XML flux from <./file_def_nemo-ice.xml> at character 2719 line 56 column 1

ÿ ^

No idea why this has changed... there is no 'ÿ' in that file or the -oce.xml. I tried a fresh checkout and get the same error.

is this under main or your branch?

atb299 commented 2 years ago

That's under my branch. I was running (or rather trying to run) yesterday and was not getting this error. I picked it up again this morning and started getting it. No idea ÿ! I checked out a fresh copy of the branch and still get the error. I'm wondering if something has changed on Archer2.

@jdha , OK, thanks. Weird ÿ error aside, do you think it's OK to merge this branch back in without looking too carefully at the output? I guess it would be good to move to the v4.2 'official release' now.

jdha commented 2 years ago

The update (https://forge.nemo-ocean.eu/nemo/nemo/-/issues/20) is now in the 4.2 release - so I guess you could address it that update. I may have a set-up of the Caribbean with and without those two updated files. If I do I'll run 2x5day to see if the fields change.