Question about categories_id

immersive-limit / coco-manager

Scripts to manage COCO datasets

MIT License

100 stars 40 forks source link

Closed Taeyoung96 closed 1 year ago

Taeyoung96 commented 3 years ago

Hi, I'm really thankful for your great code!
I have a question about categories_id.
When referring to COCO 2017 data, the category id starts from 1.

So, When you make variable new_id in _filter_categories function, I think It should start at 1.

In filter.py line 66, new_id = 1 is more appropriate.

Do you have any opinions? Thanks.

akTwelve commented 3 years ago

That’s a good point. Yes it probably should start at 1.

Taeyoung96 commented 3 years ago

@akTwelve If you don't mind, Could I make a Pull Request on these issues?