search

immersive-web / anchors

https://immersive-web.github.io/anchors/
Other
50 stars 20 forks source link

Consider merging XRAnchor and its space into an XRAnchorSpace #47

Closed Manishearth closed 4 years ago

Manishearth commented 4 years ago

This isn't something I feel strongly about, but overall it might be better to have an interface of

interface XRAnchorSpace: XRSpace {
    void delete();
}

since overall spaces are just really representations of tracked objects. We do something similar in the hands input API where the joints are just XRJointSpaces.

Apologies for posting this rather late in the process, this occurred to me after I noticed https://github.com/immersive-web/anchors/issues/46.

bialpio commented 4 years ago

I think we have discussed this in #17 & decided to stick with "has-a" approach. My 2 cents are that to me the "has-a" approach is a bit more flexible since it more firmly separates the 2 concepts & we can potentially extend the interfaces independently from each other.

Manishearth commented 4 years ago

Seems fair.