search

immersive-web / anchors

https://immersive-web.github.io/anchors/
Other
50 stars 20 forks source link

Small issue on `README.md` and `explainer.md`? #61

Closed akyeww closed 3 years ago

akyeww commented 3 years ago

Hi, just some questions related to docs.

  1. README.md Currently, the link for Explainer in README points to master branch's. Maybe update it to point to main branch's or use the relative path?

  2. explainer.md At the last part of the Explainer about sample code for Updating anchors. I'm thinking it's a typo, shouldn't xrFrame be frame instead?

    ...

for(const anchor of trackedAnchors) {
// Query most recent pose of the anchor relative to some reference space:
const pose = xrFrame.getPose(anchor.anchorSpace, referenceSpace);
}

...
himorin commented 3 years ago

added #62 for 1).

bialpio commented 3 years ago

Thanks for catching this, should be fixed now! Closing the issue.