fix motion events detection for iOS 13.4, which are broken

immersive-web / cardboard-vr-display

A JavaScript implementation of a WebVR 1.1 VRDisplay

https://immersive-web.github.io/cardboard-vr-display

Apache License 2.0

91 stars 43 forks source link

fix motion events detection for iOS 13.4, which are broken #42

Closed ivnnv closed 4 years ago

ivnnv commented 4 years ago

This will fix immersive-web/webxr-polyfill and basically any app out there which uses that webxr-polyfill (including the webxr-examples when apply the one another pre-grant permissions condition on iOS). This fix is needed because devicemotion is broken in Safari for iOS 13.4, (as it was on Chrome m65). So this PR adds the double condition to the actual isWithoutDeviceMotion variable.

jwjordan commented 4 years ago

I'd love to put in a vote for this, as this is a key component in getting aframe cardboard mode working again in iOS 13.4 (https://github.com/aframevr/aframe/issues/4554)

jsantell commented 4 years ago

Is this fixed in Safari for versions after 13_4, if there are any? I don't have iOS devices to test, but I'll get this in

jsantell commented 4 years ago

Landed in de9678d8f077ceeddf9873bb81ee43b36e9d9651 in 1.0.19