search

immersive-web / depth-sensing

Specification: https://immersive-web.github.io/depth-sensing/ Explainer: https://github.com/immersive-web/depth-sensing/blob/main/explainer.md
Other
52 stars 15 forks source link

Add support for texture arrays #42

Closed cabanier closed 1 month ago

cabanier commented 9 months ago

Preview | Diff

cabanier commented 9 months ago

@bialpio what do you think?

RaananW commented 6 months ago

Any update on this PR?

cabanier commented 6 months ago

Any update on this PR?

@toji ?

toji commented 6 months ago

Pinging @bialpio on the question I asked previously: Does the Android depth sensing use the GPU accelerated path at all?

If not, I'm inclined to say that the GL_TEXTURE_2D path should be dropped prior to merging.

bialpio commented 6 months ago

Pinging @bialpio on the question I asked previously: Does the Android depth sensing use the GPU accelerated path at all?

Ah, sorry, missed the in-review comment. No, we do not support the GPU-accelerated path for our ARCore-backed implementation on Android.

cabanier commented 6 months ago

Pinging @bialpio on the question I asked previously: Does the Android depth sensing use the GPU accelerated path at all?

Ah, sorry, missed the in-review comment. No, we do not support the GPU-accelerated path for our ARCore-backed implementation on Android.

Could we update the sample so it works on Android as well? Maybe by uploading the depth to a texture?

bialpio commented 6 months ago

Pinging @bialpio on the question I asked previously: Does the Android depth sensing use the GPU accelerated path at all?

Ah, sorry, missed the in-review comment. No, we do not support the GPU-accelerated path for our ARCore-backed implementation on Android.

Could we update the sample so it works on Android as well? Maybe by uploading the depth to a texture?

Let me look into that, I think the public sample may not have the changes that happened in our internal, for-testing sample.