search

immersive-web / hit-test

https://immersive-web.github.io/hit-test/
Other
78 stars 31 forks source link

How should XRRay.matrix be initialized for XRRay(transform)? #79

Closed takahirox closed 4 years ago

takahirox commented 4 years ago

In XRRay section, it isn't mentioned how XRRay.matrix should be initialized for XRRay(transform) while it's mentioned for XRRay(origin, direction) "Initialize ray’s matrix to null".

How should it be initialized for XRRay(transform)? Copy transform.matrix? Or set null and lazily generate as XRRay(origin, direction) does?

Manishearth commented 4 years ago

null as well, it's just null for lazy loading

takahirox commented 4 years ago

Thanks. I'll make a PR to add it.