search

immersive-web / hit-test

https://immersive-web.github.io/hit-test/
Other
78 stars 31 forks source link

Fully specify coordinate system of hit test result #89

Open bialpio opened 4 years ago

bialpio commented 4 years ago

See the discussion for #86 for details.

/cc @Manishearth

Preview | Diff

Preview | Diff

bialpio commented 1 year ago

@toji @Manishearth @cabanier - PTAL, resurrected this PR given that we now have an interop issue related to underspecification of the pose. Also fixes #114.

cabanier commented 1 year ago

@toji @Manishearth @cabanier - PTAL, resurrected this PR given that we now have an interop issue related to underspecification of the pose. Also fixes #114.

Thanks for making that change. However, we talked that we might not want to have the object aligned with the ray if it's on a vertical surface. We should either make a difference between horizontal or vertical, or make the object aligned with the orientation of the hit plane.

bialpio commented 1 year ago

Thanks for making that change. However, we talked that we might not want to have the object aligned with the ray if it's on a vertical surface.

Hmm, my intuition would be to fully specify the pose to something in all cases, and let the apps decide if they want to orient placed objects differently. And since we IMO need to fully specify the pose, we may as well specify it the same way for vertical planes as we do for horizontal planes (also note that hit-tests are not guaranteed to all come from planes, so we should probably use "hit test result normal").

We should either make a difference between horizontal or vertical, or make the object aligned with the orientation of the hit plane.

Hit test pose should already be using hit test result's normal for the Y axis - is that what you are referring to here, or is it something else?