search

immersive-web / layers

A feature repo for working on multi-layer support in WebXR. Feature leads: Rik Cabanier and Artem Bolgar (Oculus)
https://immersive-web.github.io/layers/
Other
90 stars 19 forks source link

Added support for ignoreDepthValues to XRWebGLBinding #269

Closed cabanier closed 3 years ago

cabanier commented 3 years ago

Closes https://github.com/immersive-web/webxr/issues/1228

Preview | Diff

toji commented 3 years ago

This is good overall, but the name seems a little off to me. When we use ignoreDepthValues elsewhere it's something that the user had the opportunity to set. Here it only functions as a way to communicate the system's capabilities, so a name like willIgnoreDepthValues or alwaysIgnoresDepthValues feels more appropriate.

That said, during the TPAC call we also discussed that it may be more useful to communicate that a system prefers to have depth values provided, so perhaps we should consider flipping the logic and using a name like prefersDepthValues or, more generally, usesDepthValues.

cabanier commented 3 years ago

That said, during the TPAC call we also discussed that it may be more useful to communicate that a system prefers to have depth values provided, so perhaps we should consider flipping the logic and using a name like prefersDepthValues or, more generally, usesDepthValues.

Thanks! I updated the spec so it reads usesDepthValues

Should XRProjectionLayer use the same attribute name?

toji commented 3 years ago

I could go either way on that. It's nice to have them be aligned but the context is a bit different and the attrib in the XRProjectionLayer has already shipped in at least one browser, right? I don't think that makes it unchangeable, but I also don't feel the need to break things in this case.

cabanier commented 3 years ago

I could go either way on that. It's nice to have them be aligned but the context is a bit different and the attrib in the XRProjectionLayer has already shipped in at least one browser, right? I don't think that makes it unchangeable, but I also don't feel the need to break things in this case.

Yes, we already shipped it and three is checking it.