search

immersive-web / lighting-estimation

A proposal for adding lighting estimation API to WebXR Device API. Feature lead: Kip Gilbert
https://immersive-web.github.io/lighting-estimation/
Other
32 stars 13 forks source link

Consider removing `XRLightProbe.sphericalHarmonicsOrientation` and `XRReflectionProbe.orientation` #24

Open kearwood opened 4 years ago

kearwood commented 4 years ago

The orientation of the platform specific API's lighting estimation may not match the XRSpace orientation. XRLightProbe.sphericalHarmonicsOrientation and XRReflectionProbe.orientation were included to avoid the cost of generating rotated versions of SH and cube maps.

Rather than storing the relative orientation, perhaps the UA should generate rotated variants aligned with the XRSpace of the viewer for global lighting estimation.

kearwood commented 4 years ago

If the UA generates cube maps, it should also generate mip maps. We should also define the cube maps to be in linear space, both for correct mip map generation and use within shaders.