Closed cvan closed 8 years ago
borismus
commented
8 years ago Hey Chris, short term plan was to move this repository to googlevr and add Brandon as a committer. I'd be comfortable adding others once we have a way to unit test. My main concern at this point are platform specific regressions. The iOS implementation is especially important, and feels especially fragile...
brianchirls
commented
8 years ago @borismus Sounds like a good plan, and I agree completely about iOS.
Anybody here have much experience with writing those kinds of tests? I mean, how do you automatically test device orientation on an iphone?
cvan
commented
8 years ago That all sounds good. Definitely agree re: the fragility of the Fullscreen vs. mock-Fullscreen logic. Thanks for the update.
borismus
commented
8 years ago Ownership transferred. I don't know how to automate those kinds of very OS-specific tests.
cvan
commented
8 years ago I don't know how to automate those kinds of very OS-specific tests.
Browserstack and Webdriver are the best. I've been just doing automation with PhantomJS/chrome-remote-runtime (Chromium) and SlimerJS (Firefox) though lately.
borismus
commented
8 years ago Do those test on real devices? The issues to catch so far have been very specific to iOS.
On Mon, Oct 10, 2016 at 6:16 PM chris van wiemeersch < notifications@github.com> wrote:
I don't know how to automate those kinds of very OS-specific tests.
Browserstack https://www.browserstack.com/ and Webdriver http://webdriver.io are the best. I've been just doing automation with PhantomJS/chrome-remote-runtime (Chromium) and SlimerJS (Firefox) though lately.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/googlevr/webvr-polyfill/issues/162#issuecomment-252786596, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQ8gHHAELCA6R_D4QtI5fUAnAOdlWg5ks5qyuOBgaJpZM4KSM5y .
brianchirls
commented
8 years ago @borismus: Agreed. And they're often things that require real devices or at least an iOS simulator for bugs in implementation and physical orientation. It's definitely not enough to, for example, run in Chrome Dev Tools emulator mode to check screen dimensions.
cvan
commented
8 years ago Yes, browserstack tests on real devices with video captures.
Hey, @borismus, would it be possible to give commit access to some folks? @toji, @brianchirls, and I have the most numbers of merged commits to this repo.
It would be nice to have the repo live in a WebVR community org. I've been contacted GitHub Support twice to try to get ownership of https://github.com/webvr, and they've forwarded messages of mine to the owner, but the person has never responded (and evidently has been active, but hasn't created any repos under https://github.com/webvr). Instead, I've created https://github.com/web-vr. If you'd like, we could transfer the repo there.
If not, that's fine. If you're comfortable with it, @borismus, would it be possible to grant at least commit access to @toji, @brianchirls, and myself so we could merge pull requests?