Closed thetuvix closed 4 years ago
Both I and @toji feel like the answer here is "yes"
@thetuvix I'm inclined to agree with Brandon on this one, but I want to make sure you're ok with the change since you had some concerns when originally discussed.
Sounds good to me. I can make a small PR to fix this up.
Does Daydream's clicky thing count as a trigger?
No. Daydream's main button is the touchpad. It will be mapped to buttons[2]
, but still fire the select
events. The app and home buttons are reserved by the UA and OS respectively.
Yes. This is profoundly weird. At this point it's a self correcting problem, though.
@toji hmm, the PR here is requiring a primary trigger at buttons[0]
, should that be changed?
No, that should be fine for two reasons:
xr-standard
, and that text only applies to xr-standard
devices.select
events are not explicitly bound to only a primary trigger, which is why we have all the language about identifying a "primary (select) action".Sounds good. I was careful to make sure that PR implies that the primary trigger/squeeze MUST trigger the primary actions, but others may as well.
Seems like this can be closed now that #24 is merged.
I'm fine for now to run with the onselect
and onsqueeze
events and hope that most sites power their UIs with those rather than Gamepad buttons, given the group's broader decisions around not surfacing Gamepad instances for non-controllers, such as detected hands. However, my background concern remains that we're drawing a somewhat arbitrary distinction between "buttons" from hands (e.g. select/squeeze) and "buttons" from controllers (e.g. select/squeeze) that may lead to a split in which web content supports which headsets.
If we ultimately find that too much WebXR content is making assumptions about physical gamepads specifically, UAs on hand-focused devices like HoloLens may be forced to implement virtual "Gamepads" to get content compatibility. That would be a key data point for us to ensure WebXR's post-Gamepad input API better unifies controller and hand input.
Originally posted by @NellWaliczek in https://github.com/immersive-web/webxr-gamepads-module/pull/14