search

immersive-web / webxr-hand-input

A feature repo for working on hand input support in WebXR. Feature lead: Manish Goregaokar
https://immersive-web.github.io/webxr-hand-input/
Other
104 stars 17 forks source link

Allow generic-hand #121

Closed Manishearth closed 5 months ago

Manishearth commented 5 months ago

It's unclear to me if we shoudl require "generic-hand" at all times or allow "generic-hand-select" input methods to omit "generic-hand" (thoughts @cabanier?)

Fixes https://github.com/immersive-web/webxr/issues/1358

Preview | Diff

toji commented 5 months ago

Ada mentioned on the issue:

It's odd because generic-hand is already included in the WebXR input profiles repo.

As such, this feels appropriate. LGTM

Manishearth commented 5 months ago

Ah, sorry! Will do when back at computer.

cabanier commented 5 months ago

Ah, sorry! Will do when back at computer.

yes, your change is not compatible with what we are currently doing.

Manishearth commented 5 months ago

Reverted: https://github.com/immersive-web/webxr-hand-input/pull/122

Manishearth commented 5 months ago

https://github.com/immersive-web/webxr-hand-input/pull/123 is the new PR