search

immersive-web / webxr-hand-input

A feature repo for working on hand input support in WebXR. Feature lead: Manish Goregaokar
https://immersive-web.github.io/webxr-hand-input/
Other
104 stars 17 forks source link

Reapply "Allow generic-hand" #123

Open Manishearth opened 5 months ago

Manishearth commented 5 months ago

https://github.com/immersive-web/webxr-hand-input/pull/121, take 2 (reverted in #122)

It's unclear to me if we shoudl require "generic-hand" at all times or allow "generic-hand-select" input methods to omit "generic-hand" (thoughts @cabanier?)

Fixes immersive-web/webxr#1358

Preview | Diff

Manishearth commented 5 months ago

@cabanier how is this not compatible with what Quest is doing? Currently this continues to allow the existing behavior of exposing just generic-hand-select, which was previously required for everyone.

Manishearth commented 5 months ago

@cabanier from https://github.com/immersive-web/webxr/issues/1358#issuecomment-1932759062

Looking at our code, we emit "oculus-hand", "generic-hand" and "generic-hand-select". Does VSP just emit "generic-hand"? Is Quest browser still allowed to emit "generic-hand"?

This spec change does not prevent Quest from continuing to emit generic-hand; it simply allows others to emit generic-hand and not generic-hand-select.

In fact, if Quest does emit generic-hand I'd like to change the spec text to be stronger: all hand input sources MUST include generic-hand, and all hand input sources that are primary MUST include generic-hand-select. I didn't do so since I wasn't sure if existing hand devices emit generic-hand already, but if Quest does then we can make this change stronger. Thoughts?

cabanier commented 5 months ago

@cabanier from immersive-web/webxr#1358 (comment)

Looking at our code, we emit "oculus-hand", "generic-hand" and "generic-hand-select". Does VSP just emit "generic-hand"? Is Quest browser still allowed to emit "generic-hand"?

This spec change does not prevent Quest from continuing to emit generic-hand; it simply allows others to emit generic-hand and not generic-hand-select.

In fact, if Quest does emit generic-hand I'd like to change the spec text to be stronger: all hand input sources MUST include generic-hand, and all hand input sources that are primary MUST include generic-hand-select. I didn't do so since I wasn't sure if existing hand devices emit generic-hand already, but if Quest does then we can make this change stronger.

That sounds reasonable. Can you update the PR to state this?

Manishearth commented 5 months ago

Done

cabanier commented 5 months ago

LGTM!

Manishearth commented 5 months ago

r? @toji

(and we should merge unless someone thinks this isn't ready or needs to be discussed)

toji commented 5 months ago

And I would imagine this could be merged now, but we'll probably want to bring it up as an FYI at the next call.

I would imagine that if the Quest has already been doing this then other devices/browsers are likely to have followed their lead for the sake of compatibility.

AdaRoseCannon commented 5 months ago

/agenda FYI