search

immersive-web / webxr-hand-input

A feature repo for working on hand input support in WebXR. Feature lead: Manish Goregaokar
https://immersive-web.github.io/webxr-hand-input/
Other
105 stars 17 forks source link

Remove redundant checks in getJointPose and fillPoses #97

Closed jmajnert closed 3 years ago

jmajnert commented 3 years ago

The checks for "frame's active bollean", "baseSpace session == this session" and "space's session = this session" are all already included in https://immersive-web.github.io/webxr/#populate-the-pose algorithm that is called as a step in these algorithms. I think these checks are redundant.

Preview | Diff

cabanier commented 3 years ago

I think we don't need the changes in fillPoses. Otherwise that API would partially fill in the poses until it encounters a space that fails.

jmajnert commented 3 years ago

I think we don't need the changes in fillPoses. Otherwise that API would partially fill in the poses until it encounters a space that fails.

If that is a problem, then please create a new PR with just getJointPose fixe up. Like I mentioned - I'm not a contributor and my PRs probably can't be merged.

Manishearth commented 3 years ago

(Closing since this can't be merged and is partly incorrect)